Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add AWS SDK v3 upload example #164

Closed
wants to merge 1 commit into from
Closed

feat: add AWS SDK v3 upload example #164

wants to merge 1 commit into from

Conversation

janhesters
Copy link

@janhesters janhesters commented Feb 19, 2023 •
edited
Loading

Closes #163

Description

  • Moves the "old" S3 upload example in a different folder and calls out that its for an old version of the S3 SDK.
  • Adds a new example for the new AWS S3 SDK v3.

@janhesters janhesters mentioned this pull request Feb 19, 2023
Open
@janhesters janhesters changed the title add AWS SDK v3 upload example feat: add AWS SDK v3 upload example Feb 19, 2023
akashpayne
akashpayne reviewed Mar 1, 2023
View reviewed changes
Copy link

@akashpayne akashpayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it

@janhesters
Copy link
Author

@akashpayne What needs to get done for this to get merged?

@akashpayne
Copy link

akashpayne commented Mar 13, 2023 •
edited
Loading

@mcansh @MichaelDeBoey could we get for this approved, pretty please 🙏🏽 ?

mcansh
mcansh reviewed Mar 13, 2023
View reviewed changes
Copy link
Contributor

@mcansh mcansh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the one thing that might be confusing as is, is that file-and-s3-upload-v2 sounds newer than file-and-s3-upload. can we make it file-and-s3-upload-v2 and file-and-s3-upload-v3 instead?

@janhesters
Copy link
Author

@mcansh of course! I'll try and update the code and the branch this weekend, as this week is full with work 👌

@MichaelDeBoey
Copy link
Member

Hi @janhesters!

Are you still interested in getting this one merged?

If so, please rebase onto latest main, implement remarks & resolve conflicts

@MichaelDeBoey MichaelDeBoey added the needs-response We need a response from the original author about this issue/PR label Jun 6, 2023
@janhesters
Copy link
Author

@MichaelDeBoey Yes! However, I need to find the time 🙏

@github-actions github-actions bot removed the needs-response We need a response from the original author about this issue/PR label Jun 7, 2023
@MichaelDeBoey MichaelDeBoey added the needs-response We need a response from the original author about this issue/PR label Jun 7, 2023
@github-actions
Copy link
Contributor

This PR has been automatically closed because we haven't received a response from the original author 🙈. This automation helps keep the issue tracker clean from PRs that are unactionable. Please reach out if you want to resume the work on this PR! 🙂

@github-actions github-actions bot closed this Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcansh mcansh mcansh left review comments

@akashpayne akashpayne akashpayne approved these changes

Assignees
No one assigned
Labels
needs-response We need a response from the original author about this issue/PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade S3 example to use the newest SDK.
4 participants
@janhesters @akashpayne @MichaelDeBoey @mcansh