Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n #42

Open
raucao opened this issue Oct 12, 2017 · 2 comments
Open

i18n #42

raucao opened this issue Oct 12, 2017 · 2 comments
Labels
feature

Comments

@raucao
Copy link
Member

raucao commented Oct 12, 2017

We don't have much to translate, so I think we should add as many languages as possible (and invite people to contribute translations) and use the browser's preferred language as default.

Detecting the preferred language can be done like this: https://github.com/skddc/webmarks/blob/7fc8a928452418111475141bb04a90e0b54f67fc/app/instance-initializers/i18n.js#L17-L24

What do you think?
@raucao raucao added the feature label Oct 12, 2017
@raucao
Copy link
Member Author

raucao commented Oct 12, 2017

One thing we'd need to do is decide how to treat error messages from core, because if we only emit translation IDs from there, then app developers not using the widget have to handle those as well.

@raucao
Copy link
Member Author

raucao commented Oct 17, 2017 •
edited
Loading

Idea on IRC just now was to create a seperate npm module for the translations, which we can use in the widget, but which app developers can also use for their own UI.

@raucao raucao mentioned this issue Feb 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Milestone
No milestone
Development

No branches or pull requests
1 participant
@raucao