Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove strange string exports #133

Open
viceice opened this issue Jan 11, 2022 · 8 comments
Open

Remove strange string exports #133

viceice opened this issue Jan 11, 2022 · 8 comments
Labels
breaking BREAKING CHANGE enhancement New feature or request

Comments

@viceice
Copy link
Member

viceice commented Jan 11, 2022

What would you like to be able to do?

Remove these exportes, as they aren't easily usable via esm imports

pep440/lib/operator.js

Lines 12 to 18 in 5fb26d3

"<": lt,
"<=": le,
"==": eq,
"!=": ne,
">=": ge,
">": gt,
"===": arbitrary,

Did you already have any implementation ideas?

Simply remove them. Probably breaking.

@viceice viceice added enhancement New feature or request breaking BREAKING CHANGE labels Jan 11, 2022
@viceice
Copy link
Member Author

viceice commented Jan 11, 2022

@rarkins WDYT? I't not used by renovate or pep440 code.

@RahulGautamSingh

This comment was marked as off-topic.

@viceice
Copy link
Member Author

viceice commented Jan 13, 2022

Where do you got the info from?

@RahulGautamSingh
Copy link
Contributor

RahulGautamSingh commented Jan 13, 2022

My bad. 😅 The information used to be on the landing page for @renovate/pep440.
I also hope I didn't confuse it with Renovate's users.

@viceice
Copy link
Member Author

viceice commented Jan 13, 2022

I only see one used by, maybe there where more before renaming 🤷‍♂️

We can leave this for now, as it's very low prio.

We can't make types of them, so they probably won't be usable by typescript projects.

@rarkins
Copy link
Contributor

rarkins commented Jan 14, 2022

Happy to remove these in a major bump

@viceice
Copy link
Member Author

viceice commented Jan 24, 2023

can't easily removed:

const op = Operator[spec.operator];

needs refactoring 😕

@bmeck
Copy link

bmeck commented Mar 15, 2023

these exports are usable via recent ESM https://262.ecma-international.org/13.0/#prod-ModuleExportName just use:

import { "==" as eq } from "pep440"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking BREAKING CHANGE enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants