Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: calculate semanticCommitType priority #32069

Merged

Conversation

breadadams
Copy link
Contributor

Changes

  • Introduce logic to lib/workers/repository/updates/generate.ts for getting the common semanticCommitType based on priority.
  • Add unit tests.

Context

Closes #31979

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@breadadams
Copy link
Contributor Author

I've tested this is working by running it on this repo: https://github.com/breadadams/renovate-semantic-commit-type-priority/pulls

If you compare against the original repro repo, you'll see that the new one opens both PRs with the fix prefix (as expected).

image

@breadadams breadadams requested a review from rarkins October 22, 2024 08:25
@breadadams
Copy link
Contributor Author

Hi @rarkins, is there anything missing here? Sorry for the ping, just wondering if maybe this slipped by. Thanks

@rarkins
Copy link
Collaborator

rarkins commented Oct 30, 2024

I have this saved for follow-up, just unfortunately have had little time recently

lib/workers/repository/updates/generate.ts Outdated Show resolved Hide resolved
lib/workers/repository/updates/generate.ts Outdated Show resolved Hide resolved
lib/workers/repository/updates/generate.ts Outdated Show resolved Hide resolved
lib/workers/repository/updates/generate.ts Outdated Show resolved Hide resolved
@breadadams breadadams requested a review from rarkins November 3, 2024 18:47
@rarkins rarkins enabled auto-merge December 6, 2024 09:33
@rarkins rarkins added this pull request to the merge queue Dec 6, 2024
Merged via the queue into renovatebot:main with commit c41e345 Dec 6, 2024
39 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 39.53.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add semanticCommitType awareness to generateBranchConfig()
3 participants