Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuget: support bumpVersion with centralized dependency management #32652

Open
rarkins opened this issue Nov 21, 2024 Discussed in #32452 · 0 comments
Open

Nuget: support bumpVersion with centralized dependency management #32652

rarkins opened this issue Nov 21, 2024 Discussed in #32452 · 0 comments
Labels
manager:nuget NuGeT (.NET) package manager priority-4-low Low priority, unlikely to be done unless it becomes important to more people type:feature Feature (new functionality)

Comments

@rarkins
Copy link
Collaborator

rarkins commented Nov 21, 2024

Discussed in #32452

Originally posted by jcageman November 11, 2024

Using central package management together with libraries that are versioned. When using

{
  "extends": [
    "config:recommended"
  ],
  "bumpVersion": "patch"
}

i expect version bumps on dependencies in central package management to also update the project version when there are changes.

Repro:
https://github.com/jcageman/renovate_repro_bumpversion

See also relevant PR example: https://github.com/jcageman/renovate_repro_bumpversion/pull/1/files#diff-4d59c677ea4c9112e0ce2f2e527693f48dcbcf66ba4eeb4b01abb5f3da8bbe11

Maintainer note

Today bumpVersion only works when the package file version exists in the same file as where the dependency is being updated. To achieve the above means a refactoring of generic bumpVersion logic so that it can return a different modified file to the one already modified by the dependency bump.

Reproduction forked to https://github.com/renovate-reproductions/32452

@rarkins rarkins added type:feature Feature (new functionality) priority-4-low Low priority, unlikely to be done unless it becomes important to more people manager:nuget NuGeT (.NET) package manager labels Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
manager:nuget NuGeT (.NET) package manager priority-4-low Low priority, unlikely to be done unless it becomes important to more people type:feature Feature (new functionality)
Projects
None yet
Development

No branches or pull requests

1 participant