Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(workers/repository): Pass proper lockFiles in lockFileMaintenance #27319

Merged
merged 12 commits into from
Feb 27, 2024
Merged

fix(workers/repository): Pass proper lockFiles in lockFileMaintenance #27319

Changes from 5 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
d3f864a
Workaround
not7cd Feb 15, 2024
0da176c
add PR number
not7cd Feb 15, 2024
e3e0ea8
attempt 2
not7cd Feb 15, 2024
79ebdff
Revert "Workaround"
not7cd Feb 15, 2024
9feba35
modify config before updateArtifacts
not7cd Feb 15, 2024
bf0e2fb
attempt 3
not7cd Feb 15, 2024
7f421f5
Try writing unit test
not7cd Feb 15, 2024
fa98595
Apply suggestions from code review
not7cd Feb 15, 2024
adbea9e
remove assignment
not7cd Feb 15, 2024
0b5aeb9
Merge branch 'main' of github.com:renovatebot/renovate into fix/no-lo…
not7cd Feb 19, 2024
2edbb79
Fix test by add packageFile name to upgrade
not7cd Feb 19, 2024
776c03a
Update lib/workers/repository/update/branch/get-updated.ts
not7cd Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/workers/repository/update/branch/get-updated.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,6 +361,10 @@
const packageFileContents =
updatedFileContents[packageFile] ||
(await getFile(packageFile, config.baseBranch));
// workaround, see #27319
if (config.packageFiles?.[packageFile]?.lockFiles) {

Check failure on line 365 in lib/workers/repository/update/branch/get-updated.ts

View workflow job for this annotation

GitHub Actions / lint-other 

Property 'lockFiles' does not exist on type 'PackageFile<Record<string, any>>[]'.

Check failure on line 365 in lib/workers/repository/update/branch/get-updated.ts

View workflow job for this annotation

GitHub Actions / lint-other 

Property 'lockFiles' does not exist on type 'PackageFile<Record<string, any>>[]'.

Check failure on line 365 in lib/workers/repository/update/branch/get-updated.ts

View workflow job for this annotation

GitHub Actions / build 

Property 'lockFiles' does not exist on type 'PackageFile<Record<string, any>>[]'.
not7cd marked this conversation as resolved.
Show resolved Hide resolved
config.lockFiles = config.packageFiles![packageFile].lockFiles;

Check failure on line 366 in lib/workers/repository/update/branch/get-updated.ts

View workflow job for this annotation

GitHub Actions / lint-other 

Property 'lockFiles' does not exist on type 'PackageFile<Record<string, any>>[]'.

Check failure on line 366 in lib/workers/repository/update/branch/get-updated.ts

View workflow job for this annotation

GitHub Actions / lint-other 

Property 'lockFiles' does not exist on type 'PackageFile<Record<string, any>>[]'.

Check failure on line 366 in lib/workers/repository/update/branch/get-updated.ts

View workflow job for this annotation

GitHub Actions / build 

Property 'lockFiles' does not exist on type 'PackageFile<Record<string, any>>[]'.
}
const results = await updateArtifacts({
packageFileName: packageFile,
updatedDeps: [],
Expand Down
Loading