chore: remove unnecessary window.postMessage for W3mFrame #2658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
enesozturk
reviewed
Aug 7, 2024
| @@ -124,7 +124,6 @@ export class W3mFrame { | |||
| throw new Error('W3mFrame: iframe is not set') | |||
| } | |||
| W3mFrameSchema.appEvent.parse(event) | |||
| window.postMessage(event) | |||
| this.iframe.contentWindow.postMessage(event, '*') | |||
There was a problem hiding this comment.
@zoruka Is it because the this.iframe.contentWindow.postMessage(event, '*') does the thing?
enesozturk
approved these changes
Aug 7, 2024
tomiir
approved these changes
Aug 7, 2024
…move-window-post-message
Coverage Report for Coverage
File CoverageNo changed files found. |
♻️ Vite-Size ♻️Size Difference
Current Size
Base Size
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes unnecessary
window.postMessagecall over W3mFrame when sending a message for secure site.Type of change
Associated Issues
For Linear issues: Closes APKT-xxx
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist