Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unnecessary window.postMessage for W3mFrame #2658

Merged
merged 3 commits into from
Aug 14, 2024
Merged

chore: remove unnecessary window.postMessage for W3mFrame #2658

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7661afc
fix: remove unnecessary window.postMessage for posting app event on W…
zoruka Aug 6, 2024
d1fa21d
Merge branch 'main' into fix/remove-window-post-message
tomiir Aug 7, 2024
72bc69d
Merge branch 'main' of github.com:WalletConnect/web3modal into fix/re…
zoruka Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/wallet/src/W3mFrame.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,6 @@ export class W3mFrame {
throw new Error('W3mFrame: iframe is not set')
}
W3mFrameSchema.appEvent.parse(event)
window.postMessage(event)
this.iframe.contentWindow.postMessage(event, '*')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zoruka Is it because the this.iframe.contentWindow.postMessage(event, '*') does the thing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, exactly!

}
},
Expand Down
Loading