Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deeplinks not working #2882

Merged
merged 11 commits into from
Sep 23, 2024
Merged

fix: deeplinks not working #2882

merged 11 commits into from
Sep 23, 2024

Conversation

magiziz
Copy link
Contributor

@magiziz magiziz commented Sep 19, 2024

Description

After connecting with a wallet on mobile deeplinks will fail when trying to sign a message or tx.
This is happening because this.appkit.getIsConnectedState() is always false.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-1133

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

changeset-bot bot commented Sep 19, 2024

🦋 Changeset detected

Latest commit: 324e684

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 34 packages
Name Type
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-scaffold-ui Patch
@apps/laboratory Patch
@reown/appkit Patch
@reown/appkit-common Patch
@reown/appkit-core Patch
@apps/demo Patch
@apps/gallery Patch
@examples/html-ethers Patch
@examples/html-ethers5 Patch
@examples/html-wagmi Patch
@examples/next-ethers Patch
@examples/next-wagmi Patch
@examples/react-ethers Patch
@examples/react-ethers5 Patch
@examples/react-solana Patch
@examples/react-wagmi Patch
@examples/vue-ethers5 Patch
@examples/vue-solana Patch
@examples/vue-wagmi Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-polkadot Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-ethers Patch
@reown/appkit-ethers5 Patch
@reown/appkit-polyfills Patch
@reown/appkit-siwe Patch
@reown/appkit-solana Patch
@reown/appkit-ui Patch
@reown/appkit-wagmi Patch
@reown/appkit-wallet Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Sep 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
appkit-laboratory ✅ Ready (Inspect) Visit Preview Sep 23, 2024 8:49pm
web3modal-gallery ✅ Ready (Inspect) Visit Preview Sep 23, 2024 8:49pm
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Sep 23, 2024 8:49pm

Copy link
Contributor

github-actions bot commented Sep 19, 2024

Coverage Report for Coverage

Status Category Percentage Covered / Total
🔵 Lines 241.32999999999998% 4142 / 10385
🔵 Statements 241.32999999999998% 4142 / 10385
🔵 Functions 270.67% 321 / 801
🔵 Branches 312.08% 571 / 1045
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/appkit/src/client.ts 83.06% 74.73% 87.17% 83.06% 82-83, 102-103, 106-107, 110-111, 114-117, 120-123, 126-127, 248, 256, 294-297, 397, 399-401, 404-405, 407-409, 434-435, 450-451, 454-455, 458-459, 468-470, 479, 513-517, 521, 530-542
packages/appkit/src/universal-adapter/client.ts 61.43% 53.22% 53.12% 61.43% 101-102, 137-138, 141, 149-151, 160-163, 165-167, 169-171, 173-175, 177-182, 184, 186-195, 197, 199-202, 204-209, 211, 213, 215-218, 231-233, 242-244, 246-248, 250-253, 255-256, 282-283, 301-306, 310-315, 325, 327-330, 336-344, 346, 348-349, 366-367, 369-374, 403, 412-413, 449-452, 454, 456-458, 461-464, 468-469, 471-480, 482-483, 485-488, 526-530, 535-538, 555-556, 568-570, 572-587
packages/common/src/utils/SafeLocalStorage.ts 90.69% 100% 80% 90.69% 55-58
packages/core/src/controllers/AccountController.ts 47.51% 83.33% 38.46% 47.51% 60-61, 67-70, 72-74, 77-81, 83-96, 99-100, 103-104, 107-110, 152-153, 164-165, 168-169, 172-175, 178-181, 184-188, 198-204, 207-213, 216-222, 225-228, 230-232, 234-236, 238-244, 251-252
packages/core/src/controllers/ChainController.ts 67.83% 46.66% 72.22% 67.83% 72-76, 79-83, 85-86, 88-96, 102-103, 130, 132-142, 146-154, 164-165, 188-189, 231-238, 243-244, 286-289, 300-302, 304-305, 314-315, 334-336, 338-339, 342-343, 348-349, 352-353, 365-366, 369-370, 375-376, 388-389, 394-395, 401, 403-408, 410-411, 414, 416-421, 423-424, 430-431
packages/core/src/utils/StorageUtil.ts 75% 74.07% 90.9% 75% 49-50, 59-60, 62, 69-70, 77-78, 80, 87-88, 95-96, 98, 105-106, 108, 112-116, 118-119
Generated in workflow #6277

Copy link
Contributor

github-actions bot commented Sep 19, 2024

♻️ Vite-Size ♻️

Size Difference

Size (kb) Gzip (kb)
Total Diff. 0 0

Current Size

Name Size (kb) Gzip (kb)
assets/index-BRaaCTq4.js 1866.8 532.907
assets/index.js 9.63 3.16
assets/index2.js 11.572 3.198
assets/w3m-modal.js 7.397 2.615
assets/noble-curves.js 31.941 12.778
assets/2.21.4_bufferutil.js 2.789 1.327
assets/index3.js 102.251 29.116
assets/index4.js 304.393 87.285
assets/hooks.module.js 74.443 25.59
index.html 0.329 0.237
Total Size 2411.545 698.213

Base Size

Name Size (kb) Gzip (kb)
assets/index-BRaaCTq4.js 1866.8 532.907
assets/index.js 9.63 3.16
assets/index2.js 11.572 3.198
assets/w3m-modal.js 7.397 2.615
assets/noble-curves.js 31.941 12.778
assets/2.21.4_bufferutil.js 2.789 1.327
assets/index3.js 102.251 29.116
assets/index4.js 304.393 87.285
assets/hooks.module.js 74.443 25.59
index.html 0.329 0.237
Total Size 2411.545 698.213

@magiziz
Copy link
Contributor Author

magiziz commented Sep 20, 2024

Seems like something that got merged in main broke this PR

@magiziz magiziz force-pushed the fix/walletconnect-deeplink-failure branch 2 times, most recently from 8738ceb to 83e48eb Compare September 20, 2024 17:23
@tomiir tomiir merged commit aaa22cf into main Sep 23, 2024
17 checks passed
@tomiir tomiir deleted the fix/walletconnect-deeplink-failure branch September 23, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants