Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit Disconnect event properly on connection reset without handshake #33

Open
Rakowskiii opened this issue Jun 20, 2023 · 0 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@Rakowskiii
Copy link
Contributor

The websocket relay client will currently only emit Error event when the connection is finished not gracefully. It should also emit Disconnected otherwise consumer may think the connection is intact, while in fact it's dead.

This is what happens currently (e.g. when relay is redeployed)

[cast-client] inbound error: Websocket client error: Websocket transport error: WebSocket protocol error: Connection reset without closing handshake

@Rakowskiii Rakowskiii self-assigned this Jun 20, 2023
@Rakowskiii Rakowskiii added the bug Something isn't working label Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants
@Rakowskiii and others