Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support blocking subscriptions #56

Merged
merged 2 commits into from
Jan 17, 2024
Merged

feat: support blocking subscriptions #56

merged 2 commits into from
Jan 17, 2024

Conversation

heilhead
Copy link
Collaborator

Description

This adds support for 'blocking' subscriptions, i.e. disabling the optimistic response by the relay.

How Has This Been Tested?

Existing tests.

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@heilhead heilhead mentioned this pull request Jan 17, 2024
Merged
3 tasks
arein
arein approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@arein arein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a note that this is experimental and will likely be removed

relay_client/src/http.rs Outdated Show resolved Hide resolved
@heilhead heilhead merged commit d2a772f into main Jan 17, 2024
8 checks passed
@heilhead heilhead deleted the feat/blocking-subscriptions branch January 17, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xDarksome xDarksome xDarksome approved these changes

@arein arein arein approved these changes

@chris13524 chris13524 Awaiting requested review from chris13524

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heilhead @arein @xDarksome