Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No internet connection error #6

Open
AmjadKhan2k18 opened this issue Oct 3, 2024 · 2 comments
Open

No internet connection error #6

AmjadKhan2k18 opened this issue Oct 3, 2024 · 2 comments
Assignees
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request

Comments

@AmjadKhan2k18
Copy link

Describe the bug
I have a phone for testing in which I can't turn on wifi or data, And I use cable to share internet from Computer while testing.

So basically I have internet connection on this device but the Reown return error that i have no internet when .connect method is executed

ReownCoreError(code: -1, message: No internet connection, data: null)

To Reproduce
Steps to reproduce the behavior:

  1. Turn off Wifi/data on your phone
  2. Use cable to share internet to your phone from Computer
  3. Connect to any Wallet
  4. See error

Expected behavior
User should be able to connect if Wifi/Data is off but have internet connection, we should check if user have internet not Wifi/Data

Reproducible code

final res = await wcClient!.reOwnSign.connect(
        optionalNamespaces: {
          'eip155': RequiredNamespace(
            chains: Web3Helper.getChains(wallet.web3Wallet),
            methods: Web3Helper.rpcOptionalMethods,
            events: Web3Helper.rpcEvents,
          ),
          // 'tron': RequiredNamespace(
          //   chains: [
          //     "tron:0x2b6653dc",
          //   ], // Ethereum chain/ Ethereum chain
          //   methods: ['tron_signTransaction', 'tron_signMessage'],
          //   events: [],
          // ),
        },
      );

Smartphone (please complete the following information):

  • Device: [e.g. Iphone X
@quetool
Copy link
Member

quetool commented Oct 4, 2024

Hello @AmjadKhan2k18, we use connectivity_plus package to determine wether the device is connected or not and it seems like in your particular case (quite an edge case I'd say) this package can't determine you are connected. I'll share your issue with the team but I really think you should ping connectivity_plus devs about this as it should be fixed in their side.

@quetool
Copy link
Member

quetool commented Nov 25, 2024

Hello @AmjadKhan2k18! We are gonna enhance this in the coming version. Are you still affected by this?

@quetool quetool added enhancement New feature or request dependencies Pull requests that update a dependency file labels Nov 25, 2024
@quetool quetool self-assigned this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants