Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNSRecords that don't contain domain suffix aren't reconciled properly #18

Open
diamonwiggins opened this issue Aug 1, 2021 · 0 comments

Comments

@diamonwiggins
Copy link
Member

diamonwiggins commented Aug 1, 2021

Example:

apiVersion: crds.kubeflare.io/v1alpha1
kind: DNSRecord
metadata:
  name: diamon-codeserver-test.repldev.com
spec:
  zone: repldev.com
  record:
    type: "A"
    name: "diamon-codeserver-test"
    content: "34.94.103.105"
    proxied: true
    ttl: 3600

The above is created, but never will never be updated properly due to:

https://github.com/replicatedhq/kubeflare/blob/master/pkg/controller/dnsrecord/dns_records.go#L37-L40

desiredRecord.Name never matches existingRecord.Name because of the missing domain suffix.

@diamonwiggins diamonwiggins changed the title DNSRecords that don't contain Domain Suffix aren't reconciled properly DNSRecords that don't contain domain suffix aren't reconciled properly Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant