Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Quick fix for handling non 200 status codes when loading specs from URI #1695

Conversation

hedge-sparrow
Copy link
Member

@hedge-sparrow hedge-sparrow commented Nov 25, 2024

Go http client already handles 3xx responses for us

Description, Motivation and Context

Please include a summary of the change or what problem it solves. Please also include relevant motivation and context.

Fixes: #1694

Checklist

  • New and existing tests pass locally with introduced changes.
  • Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) are informative and highlight any breaking changes
  • Any documentation required has been added/updated. For changes to https://troubleshoot.sh/ create a PR here

Does this PR introduce a breaking change?

  • Yes
  • No

@hedge-sparrow hedge-sparrow requested a review from a team as a code owner November 25, 2024 14:24
@hedge-sparrow hedge-sparrow added the type::bug Something isn't working label Nov 25, 2024
@hedge-sparrow hedge-sparrow merged commit ecc92b1 into main Nov 25, 2024
24 checks passed
@hedge-sparrow hedge-sparrow deleted the ash-jones/sc-116285/uri-fields-with-unexpected-content-cause branch November 25, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug::normal type::bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URI field that returns content that isn't a support bundle causes analysis to fail
2 participants