Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@codemirror/[email protected] + Chrome v126 - Enter not inserting new line in insert or normal mode #182

Open
infime opened this issue Jul 16, 2024 · 2 comments

Comments

@infime
Copy link

infime commented Jul 16, 2024

Seems likely to have something to do with the new EditContext API usage (https://github.com/codemirror/view/blob/ed78a0cbb6852c02acc93c85cbabe0ac12ab13c1/CHANGELOG.md#new-features).

Still works as expected on 6.28.1 + Chrome v126

@nightwing
Copy link
Collaborator

Do you see this on https://raw.githack.com/replit/codemirror-vim/master/dev/web-demo.html, or with another configuration? I couldn't reproduce the bug with chrome 126 on windows with the above link.

@nightwing
Copy link
Collaborator

@infime did you include basicSertup, or https://codemirror.net/docs/ref/#commands.standardKeymap in your codemirror setup? Seems like the change is in codemirror itself which does not insert new lines without standardCommands if EditContext mode is active.

lutzky added a commit to lutzky/silverbullet that referenced this issue Nov 11, 2024
zefhemel pushed a commit to silverbulletmd/silverbullet that referenced this issue Nov 11, 2024
This is a workaround for replit/codemirror-vim#182

Fixes #1145 (harder)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants