Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null access error throw with command in keydown handler #90

Open
sergeichestakov opened this issue Mar 3, 2023 · 3 comments
Open

Null access error throw with command in keydown handler #90

sergeichestakov opened this issue Mar 3, 2023 · 3 comments
Assignees

Comments

@sergeichestakov
Copy link
Contributor

looks like command can be null here in some rare cases so CM Vim will throw an error when we try to access it's types as part of the keydown handler. Seems to be a more recent regression. Not sure if this is something we should be checking for.

Hard to get an exact repro but here's a screenshot of the stack trace we've seen in the wild:

Screenshot 2023-03-03 at 11 37 34 AM

@sergeichestakov
Copy link
Contributor Author

@nightwing can you take a look please?

@nightwing
Copy link
Collaborator

I have tried to track this down but without much success unfortunately. I'll try to add types to vim.js maybe it will help to track down the issue.

Alternatively i can try to add more info to the error log, it might help, if the error happens often on replit.

@sergeichestakov
Copy link
Contributor Author

Gotcha yeah this is happening pretty infrequently. We just saw it in our logs. Perhaps we can bail if command is undefined? Although not sure myself how that would happen.

Also, it would be great to type vim.js but we can tackle that separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants