Update x64/Arm Mac runners in GH Actions #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeichestakov
requested review from
a team,
moudy,
szymonkaliski and
ink404
and removed request for
a team
ryantm
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
I found out today that the
macos-latestGH actions runner got switched out from under our feet in the past month since we last published and now the machine that runs those actions is an Apple Silicon (ARM) chip instead of an older Intel-based Mac. See relevant changelog: https://github.blog/changelog/2024-04-01-macos-14-sonoma-is-generally-available-and-the-latest-macos-runner-image/The implication of this is that now both our "x64" and "arm64" jobs in GH actions are, in fact, producing arm64 based artifacts.
What changed
Update x64/Arm Mac runners in GH Actions. Now, the macos-latest runner corresponds to Apple Silicon (ARM) machines, meaning we no longer need the xlarge runner, and the
macOS-12runner corresponds to Intel chip builds.Test plan
Should produce 2 separate DMGs, one for each architecture, on next run 🤞 In the meantime, the "runner details" in the GH actions logs in CI should indicate that they are running on the appropriate architecture.