From 9acf7ba86ea0b9b6876f97c3788cb40181502669 Mon Sep 17 00:00:00 2001
From: Szymon Kaliski <hi@szymonkaliski.com>
Date: Thu, 29 Feb 2024 14:24:53 +0000
Subject: [PATCH] add a test that runs multiple ptys

---
 bun.lockb     | Bin 21351 -> 21351 bytes
 flake.nix     |   5 +++--
 index.test.ts |  61 ++++++++++++++++++++++++++------------------------
 3 files changed, 35 insertions(+), 31 deletions(-)

diff --git a/bun.lockb b/bun.lockb
index 50a1bf2d3b0915389a0de113421b50669618e70c..9727b69fec18dc8d029401af7f7b91a1fd2562b7 100755
GIT binary patch
delta 23
ecmaF9jPdz0#tmN992|^s#(GA2CYyt-MI``dv<D*q

delta 23
bcmaF9jPdz0#tmN99863MV6ZvJT2ul6Tfzm)

diff --git a/flake.nix b/flake.nix
index b04fca6..41d96c9 100644
--- a/flake.nix
+++ b/flake.nix
@@ -1,8 +1,8 @@
 {
   inputs.nixpkgs.url = "github:NixOS/nixpkgs/nixpkgs-unstable";
 
-  outputs = { self, nixpkgs }: 
-  let 
+  outputs = { self, nixpkgs }:
+  let
     mkDevShell = system:
     let
       pkgs = nixpkgs.legacyPackages.${system};
@@ -20,5 +20,6 @@
   {
     devShells.aarch64-darwin.default = mkDevShell "aarch64-darwin";
     devShells.x86_64-darwin.default = mkDevShell "x86_64-darwin";
+    devShells.x86_64-linux.default = mkDevShell "x86_64-linux";
   };
 }
diff --git a/index.test.ts b/index.test.ts
index 6ad32e0..669b60d 100644
--- a/index.test.ts
+++ b/index.test.ts
@@ -8,7 +8,7 @@ describe('PTY', () => {
     const message = 'hello from a pty';
 
     const pty = new Pty(
-      '/bin/echo',
+      'echo',
       [message],
       {},
       CWD,
@@ -29,7 +29,7 @@ describe('PTY', () => {
 
   test('captures an exit code', (done) => {
     new Pty(
-      '/bin/sh',
+      'sh',
       ['-c', 'exit 17'],
       {},
       CWD,
@@ -42,17 +42,34 @@ describe('PTY', () => {
     );
   });
 
+  test('can be started many times', (done) => {
+    const num = 100;
+    let exited = Array.from({ length: num }).map(() => false);
+
+    for (let i = 0; i < num; i++) {
+      new Pty(
+        'sh',
+        ['-c', `exit 0`],
+        {},
+        CWD,
+        { rows: 24, cols: 80 },
+        (err, exitCode) => {
+          exited[i] = true;
+          expect(err).toBeNull();
+          expect(exitCode).toBe(0);
+
+          if (!exited.some((x) => x === false)) {
+            done();
+          }
+        },
+      );
+    }
+  });
+
   test('can be written to', (done) => {
     const message = 'hello cat';
 
-    const pty = new Pty(
-      '/bin/cat',
-      [],
-      {},
-      CWD,
-      { rows: 24, cols: 80 },
-      () => {},
-    );
+    const pty = new Pty('cat', [], {}, CWD, { rows: 24, cols: 80 }, () => {});
 
     const readStream = fs.createReadStream('', { fd: pty.fd });
     const writeStream = fs.createWriteStream('', { fd: pty.fd });
@@ -66,14 +83,7 @@ describe('PTY', () => {
   });
 
   test('can be resized', (done) => {
-    const pty = new Pty(
-      '/bin/sh',
-      [],
-      {},
-      CWD,
-      { rows: 24, cols: 80 },
-      () => {},
-    );
+    const pty = new Pty('sh', [], {}, CWD, { rows: 24, cols: 80 }, () => {});
 
     const readStream = fs.createReadStream('', { fd: pty.fd });
     const writeStream = fs.createWriteStream('', { fd: pty.fd });
@@ -101,7 +111,7 @@ describe('PTY', () => {
 
   test('respects working directory', (done) => {
     const pty = new Pty(
-      '/bin/pwd',
+      'pwd',
       [],
       {},
       CWD,
@@ -120,12 +130,12 @@ describe('PTY', () => {
     });
   });
 
-  test.skip('respects env', (done) => {
+  test('respects env', (done) => {
     const message = 'hello from env';
     let buffer = '';
 
     const pty = new Pty(
-      '/bin/sh',
+      'sh',
       ['-c', 'sleep 0.1s && echo $ENV_VARIABLE && exit'],
       {
         ENV_VARIABLE: message,
@@ -151,14 +161,7 @@ describe('PTY', () => {
   test('works with Bun.read & Bun.write', (done) => {
     const message = 'hello bun';
 
-    const pty = new Pty(
-      '/bin/cat',
-      [],
-      {},
-      CWD,
-      { rows: 24, cols: 80 },
-      () => {},
-    );
+    const pty = new Pty('cat', [], {}, CWD, { rows: 24, cols: 80 }, () => {});
 
     const file = Bun.file(pty.fd);