Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.2.2 end tty stream cleanly on error #46

Merged
merged 5 commits into from
Oct 4, 2024
Merged

3.2.2 end tty stream cleanly on error #46

merged 5 commits into from
Oct 4, 2024

Conversation

jackyzha0
Copy link
Member

  • don't .destroy, .end instead
  • add previously failing test resize after close shouldn\'t throw
  • check the fd is still valid before we try to resize

@jackyzha0 jackyzha0 changed the title dont try to resize if we invalidated the fd 3.2.2 dont try to resize if we invalidated the fd Oct 4, 2024
@jackyzha0 jackyzha0 changed the title 3.2.2 dont try to resize if we invalidated the fd 3.2.2 end tty stream cleanly on error Oct 4, 2024
lhchavez
lhchavez approved these changes Oct 4, 2024
View reviewed changes
wrapper.ts Show resolved Hide resolved
@jackyzha0 jackyzha0 merged commit 417a4d3 into main Oct 4, 2024
4 checks passed
@jackyzha0 jackyzha0 deleted the jackyzha0/resize-robustness branch October 4, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhchavez lhchavez lhchavez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackyzha0 @lhchavez