Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for running with different builder #45

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

ty2
Copy link
Contributor

@ty2 ty2 commented Nov 7, 2024

Introduced builder arguments to specify custom builder.

README.md Outdated Show resolved Hide resolved
@AkihiroSuda
Copy link
Member

AkihiroSuda commented Nov 12, 2024

Please rebase and rebuild the dist:

Also please squash the commits

@ty2
Copy link
Contributor Author

ty2 commented Nov 12, 2024

Please rebase and rebuild the dist:

Also please squash the commits

Done.

@AkihiroSuda
Copy link
Member

Commits do not seem squashed

https://www.freecodecamp.org/news/git-squash-commits/

pnpm-lock.yaml Outdated Show resolved Hide resolved
@ty2 ty2 force-pushed the main branch 2 times, most recently from dd860b2 to ba9d021 Compare November 12, 2024 05:47
Signed-off-by: Terry Wong <[email protected]>

rebuild

Signed-off-by: Terry Wong <[email protected]>
@ty2
Copy link
Contributor Author

ty2 commented Nov 12, 2024

Sorry, I'm not familiar with Git. It looks like the commits have been squashed. Could you check if there are any issues?

Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit 61bd187 into reproducible-containers:main Nov 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants