Kauana tomb #22
Open
Kauana tomb #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camilamlima
reviewed
Sep 21, 2023
|
|
||
| sacar(valor) { | ||
| if (valor > this.saldo) { | ||
| if (valor > this.limite) { |
There was a problem hiding this comment.
Olá Kauana, primeiramente parabéns pelo projeto, você validou todos os cenários. Como sugestão você poderia validar o saque em um único if.
if (valor > this.saldo && valor > this.limite){
throw new Error('Saldo insuficiente')
}
Outro ponto acredito que o Else ficou um pouco confuso usando saldo e limite
this.limite = this.limite - valor
this.saldo = this.saldo - valor
}
Mais uma vez parabéns pelo código e dedicação se precisar de ajuda, conte comigo!
camilamlima
reviewed
Sep 22, 2023
There was a problem hiding this comment.
Esse arquivo pode ser excluído, já que os códigos estão nos outros arquivos.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
O que?
Resolução do exercício para casa
Como?
Adicionei o arquivo bankAccount.js com a minha resolução para a atividade
Adicionei casos de testes unitários para o exercício utilizando jest no arquivo bankAccount.test.js