Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSONschema editors: form addons are not translated #3547

Open
PascalRepond opened this issue Nov 30, 2023 · 1 comment · Fixed by rero/ng-core#579
Open

JSONschema editors: form addons are not translated #3547

PascalRepond opened this issue Nov 30, 2023 · 1 comment · Fixed by rero/ng-core#579
Labels
bug Breaks something but is not blocking

Comments

@PascalRepond
Copy link
Contributor

Bug description:

Some JSONschemas define addonRight template option to add info to a field. These strings are not translated.

Example in the circulation policy editor:
image

Expected behavior:

When form addons are text, they should be translated in the editor for the user.
@PascalRepond PascalRepond added the bug Breaks something but is not blocking label Nov 30, 2023
@PascalRepond PascalRepond moved this from Inbox to Product Backlog in RERO ILS issues Dec 21, 2023
Garfield-fr added a commit to Garfield-fr/ng-core that referenced this issue Jan 8, 2024
@Garfield-fr
editor: fix addonRight and addLeft translation
3e67914 
* Closes rero/rero-ils#3547.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/ng-core that referenced this issue Jan 8, 2024
@Garfield-fr
editor: fix addonRight and addLeft translation
f70ea3f 
* Closes rero/rero-ils#3547.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/ng-core that referenced this issue Jan 8, 2024
@Garfield-fr
editor: fix addon right and left translation
f3650d3 
* Closes rero/rero-ils#3547.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@Garfield-fr Garfield-fr mentioned this issue Jan 8, 2024
Merged
@Garfield-fr Garfield-fr moved this from Product Backlog to In Development in RERO ILS issues Jan 8, 2024
Garfield-fr added a commit to Garfield-fr/ng-core that referenced this issue Jan 8, 2024
@Garfield-fr
editor: fix addon right and left translation
74c3402 
* Closes rero/rero-ils#3547.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@Garfield-fr Garfield-fr moved this from In Development to Ready to test in RERO ILS issues Jan 8, 2024
Garfield-fr added a commit to Garfield-fr/ng-core that referenced this issue Jan 9, 2024
@Garfield-fr
editor: fix addon right and left translation
7040054 
* Closes rero/rero-ils#3547.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/ng-core that referenced this issue Jan 10, 2024
@Garfield-fr
editor: fix addon right and left translation
d656faf 
* Closes rero/rero-ils#3547.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/ng-core that referenced this issue Jan 10, 2024
@Garfield-fr
editor: fix addon right and left translation
5ec5b6d 
* Closes rero/rero-ils#3547.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to rero/ng-core that referenced this issue Jan 10, 2024
@Garfield-fr
editor: fix addon right and left translation
c45e6dd 
* Closes rero/rero-ils#3547.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/ng-core that referenced this issue Jan 10, 2024
@Garfield-fr
editor: fix addon right and left translation
88a6982 
* Closes rero/rero-ils#3547.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to rero/ng-core that referenced this issue Jan 10, 2024
@Garfield-fr
editor: fix addon right and left translation
f9988d9 
* Closes rero/rero-ils#3547.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to rero/ng-core that referenced this issue Jan 11, 2024
@Garfield-fr
editor: fix addon right and left translation
628ee35 
* Closes rero/rero-ils#3547.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@github-project-automation github-project-automation bot moved this from Ready to test to Done in RERO ILS issues Jan 11, 2024
@PascalRepond
Copy link
Contributor Author

Regressed in v1.22.1

@PascalRepond PascalRepond reopened this Jul 26, 2024
@github-project-automation github-project-automation bot moved this from Done to Product Backlog in RERO ILS issues Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Breaks something but is not blocking
Projects
RERO ILS issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

editor: fix addon right and left translation Garfield-fr/ng-core
1 participant
@PascalRepond