Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to tungstenite 0.23 #39

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Update to tungstenite 0.23 #39

merged 1 commit into from
Jun 5, 2024

Conversation

Its-Just-Nans
Copy link
Contributor

@Its-Just-Nans Its-Just-Nans commented Jun 5, 2024 •
edited
Loading

Linked to #27

@emilk emilk changed the title bump tungstenite Update to tungstenite 0.23 Jun 5, 2024
emilk
emilk approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@emilk emilk added enhancement New feature or request include in changelog Include this in CHANGELOG.md labels Jun 5, 2024
@emilk emilk merged commit 1a9e78a into rerun-io:main Jun 5, 2024
7 of 8 checks passed
@Its-Just-Nans Its-Just-Nans deleted the bump-tungstenite branch June 5, 2024 15:12
@emilk emilk mentioned this pull request Oct 10, 2024
Closed
@emilk
Copy link
Member

emilk commented Oct 10, 2024

This broke the text/example:

@Its-Just-Nans
Copy link
Contributor Author

I currently see that the example is working

I guess the fix was #45

Conclusion: example_app is working now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request include in changelog Include this in CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Its-Just-Nans @emilk