Make SeriesLine visualizer work with several scalars per time
#9033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Web viewer failed to build.
Note: This comment is updated whenever you push a commit. |
Wumpf
commented
Feb 13, 2025
crates/viewer/re_view_time_series/src/line_visualizer_system.rs
Outdated
Show resolved
Hide resolved
I actually would like to make this part of the Plots example. This is valuable both for our users and us, as something easily accessible from the welcome screen. (Case in point, I would have liked to try out this feature in the web viewer generated for this PR) |
teh-cmc
approved these changes
Feb 14, 2025
Wumpf
added a commit
that referenced
this pull request
Feb 14, 2025
* Fixes #9031 Adds a small handful of tests to the time series. Replaces the `check_scalar_clears.py` manual test. We have other manual tests involving plots but they are all about overrides which I considered out of scope for this round of testing for the very moment. Upcoming TODO: Add multi-plot version for * #9033
Wumpf
added a commit
that referenced
this pull request
Feb 17, 2025
Follow-up to both * #9036 * #9033 Since the code paths for multiple time series (mostly due to optimization) can vary quite a bit, I duplicated the previously added tests to account for this. Point series don't yet support multiple series on a single entity, so all errors around them are expected - once we implement #9020 these tests should then automatically reflect this. Fixed an issue when the number of names specified is smaller than the number of series -- this sort of issue led me to adding a third variant where we have a have a single property but multiple series. This ensure that splatting where appropriate happens.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
What
Try the example in the browser:
https://rerun.io/viewer/pr/9033?url=https://static.rerun.io/rrd/0.22.0/multiplot_0a77742f7ddd55361c4b7bd9976caa1cc45f9c14.rrd
SeriesLinevisualizer now operates as-if...In other words: Single entity, multiple plots
To test this out I added a manual "test" for now (to be removed again) which tests both static & varying color & widths as well as gaps.
In a follow-up I'll add automated tests for this.
This PR intentionally does NOT touch any APIs. Logging happens right now via the same generic APIs we use for column batches. That API didn't really make sense before here but works pretty much how one would expect, begging the question if this isn't already good enough 🤔
Performance before/after was verified to be unchanged using
cargo run --release --bin plot_dashboard_stress -- --num-plots 16 --num-series-per-plot 32(curiously it actually improved a lil bit from 30.1ms 29.6ms overall viewer time but that's probably just measurement fluctuation / background task activity)