Optionally include static chunks in the chunk store range query for al… #9044
+23
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
teh-cmc
reviewed
Feb 14, 2025
Comment on lines
+790
to
+806
| if include_static { | ||
| let static_chunks = self | ||
| .static_chunk_ids_per_entity | ||
| .get(entity_path) | ||
| .map(|static_chunks_per_component| { | ||
| static_chunks_per_component | ||
| .values() | ||
| .filter_map(|chunk_id| self.chunks_per_chunk_id.get(chunk_id).cloned()) | ||
| .collect_vec() | ||
| }) | ||
| .unwrap_or_default(); | ||
|
|
||
| debug_assert!(static_chunks.iter().map(|chunk| chunk.id()).all_unique()); | ||
| static_chunks.into_iter().chain(chunks).collect() | ||
| } else { | ||
| chunks | ||
| } |
There was a problem hiding this comment.
You need to do this first, and then for every component that didn't get any static chunks (and only those), extend the results with the existing temporal logic.
There was a problem hiding this comment.
that makes sense, tnx
|
(Reminder to do the same for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^.