Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace Codecs.re #25

Open
mrmurphy opened this issue Sep 6, 2019 · 5 comments
Open

Namespace Codecs.re #25

mrmurphy opened this issue Sep 6, 2019 · 5 comments
Labels
good first issue Good for newcomers

Comments

@mrmurphy
Copy link
Contributor

mrmurphy commented Sep 6, 2019

"Codecs" is a name that I like to use in my top-level projects, and I've run into problems with my module colliding with Decco's "Codecs" module. Would you consider namespacing, so that "Codecs" becomes "Decco_Codecs" and can be used like this: "Decco.Codecs"?

@mrmurphy
Copy link
Contributor Author

mrmurphy commented Sep 6, 2019

This could also be a good first issue for a contributor.

@ryb73 ryb73 added the good first issue Good for newcomers label Sep 6, 2019
@ryb73
Copy link
Member

ryb73 commented Sep 6, 2019

Sure, seems like a reasonable change. It's kind of annoying that this is a problem, I'd like to see some movement on rescript-lang/rescript#3324 or rescript-lang/rescript#2688 but it seems like they're not prioritized :/

@idkjs
Copy link

idkjs commented Dec 3, 2019

Hey folks. I figured I would take a shot at this. When i go to build the project the test directory blows up. Are there build instructions available? yarn watch and yarn watch-ppx didnt get it done for me. Thank you.

@ryb73
Copy link
Member

ryb73 commented Dec 5, 2019

@idkjs no build instructions exist currently, but you can look at .travis.yml to get a general idea. Looks like you're already on the right track though.

You may need to run yarn build-ppx before running yarn watch-ppx. Have you tried that? What error message are you getting? What do you mean by the test directory "blowing up"? What OS are you using?

@idkjs
Copy link

idkjs commented Dec 5, 2019

@ryb73 running yarn build-ppx first did the trick. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants