Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About ablation study on memory mechanism #52

Open
liziming5353 opened this issue Apr 25, 2024 · 14 comments
Open

About ablation study on memory mechanism #52

liziming5353 opened this issue Apr 25, 2024 · 14 comments

Comments

@liziming5353
Copy link

How is the model without the MM module implemented in the ablation experiment? Is it directly applying the merge algorithm to the entire video?

@Espere-1119-Song
Copy link
Collaborator

We just select several frames, feed them into LLM decoder without merge algorithm

@liziming5353
Copy link
Author

Got it. What's the difference between video_path and fragment_video_path? In my understanding, video_path is the path to the video to be processed. But in upload_video_without_audio function in chat_model.py, fragment_video_path is used as a parameter of load_video function.

@Espere-1119-Song
Copy link
Collaborator

fragment_video_path stores the video clips read by the sliding window

@liziming5353
Copy link
Author

So need I prepare the video clips in advance or it will be generated automatically?

@Espere-1119-Song
Copy link
Collaborator

no needs, it will be generated automatically

@liziming5353
Copy link
Author

Where does it generated? I don't find it. The first time fragment_video_path is used seems to be as a parameter of load_video in upload_video_without_audio function.

@liziming5353
Copy link
Author

image

@Espere-1119-Song
Copy link
Collaborator

you can run it and print the path to see:)

@liziming5353
Copy link
Author

I have run it. I set the fragment_video_path to "~/video_frames_moviechat" which is an empty folder. An error occurred:
image

@Espere-1119-Song
Copy link
Collaborator

because fragment_video_path needs to be a mp4 file, not a dictionary:)

@liziming5353
Copy link
Author

So fragment_video_path and video_path are the same video?

@Espere-1119-Song
Copy link
Collaborator

no, fragment_video_path is a tmp mp4 file

@liziming5353
Copy link
Author

But I only have one video to be processed and you said that fragment_video_path will be generated. So I am confused... Could you give me a sample?

@liziming5353
Copy link
Author

It seems a bug in pypi code. In github code, the capture_video function write the tmp video file, and return the path. But in pypi code, the capture_video function does not write the tmp video file but still return the path. So the error above occurred.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants