Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace library version system. #449

Closed
jgalan opened this issue Jun 16, 2023 · 2 comments · Fixed by #450
Closed

Replace library version system. #449

jgalan opened this issue Jun 16, 2023 · 2 comments · Fixed by #450
Assignees
Labels
cmake Related to CMake enhancement New feature or request

Comments

@jgalan
Copy link
Member

jgalan commented Jun 16, 2023

Up to now we update the library version inside CMakeLists.txt manually. I think a more efficienct way would be to read the latest git tag name inside the cmake system so that just tagging is enough to define a human version.

What do you think?

the cmake variable LIBRARY_VERSION inside cmake could be simply filled by a call to a git command that returns the latest tag.

@lobis lobis added enhancement New feature or request cmake Related to CMake labels Jun 16, 2023
@jgalan
Copy link
Member Author

jgalan commented Jun 16, 2023

I have already implemented a preliminary here: rest-for-physics/rawlib@608d4f3 and here rest-for-physics/rawlib#110

@lobis
Copy link
Member

lobis commented Jun 16, 2023

I was already working on this also, I have it almost finished, submitting the PR in a few minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmake Related to CMake enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants