Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpfr on docker imager #3

Open
jgalan opened this issue Jul 26, 2023 · 5 comments
Open

mpfr on docker imager #3

jgalan opened this issue Jul 26, 2023 · 5 comments

Comments

@jgalan
Copy link
Member

jgalan commented Jul 26, 2023

It is clear now that we have to remove mpreal.h from the https://github.com/rest-for/physics/framework repository, and simply install sudo apt-get install libmpfrc++-dev.

This is related to the following PR.

rest-for-physics/framework#407

Do we have a docker image with libmpfrc++-dev included? Then, plz, @lobis, it is possible to update the docker image at rest-for-physics/framework#407, fix the validation pipeline and fix it?

@lobis
Copy link
Member

lobis commented Jul 26, 2023

The current latest docker image has the dependency (https://github.com/rest-for-physics/rest-docker/blob/main/root/dependencies/general).

However the framework is not currently using the image defined in this repository for validation due to some other issues. I don't quite remember what was the problem but I think it was related to some other issue that is probably fixed now, hopefully whatever is failing can be fixed easily and we can merge PRs such as rest-for-physics/framework#365.

@jgalan
Copy link
Member Author

jgalan commented Jul 29, 2023

It seems the failure at rest-for-physics/framework#365 is due to GEOM_SCALE not found. It seems the pipeline is picking an old Geant4lib version. Since GEOM_SCALE was replaced by fGeomScale at the following PR https://github.com/rest-for-physics/geant4lib/pull/108/files

@jgalan
Copy link
Member Author

jgalan commented Jul 30, 2023

I merged rest-for-physics/framework#365 on rest-for-physics/framework#407. So that it uses this docker image.

Still it looks like it does not find mpreal.h.

https://github.com/rest-for-physics/framework/actions/runs/5700965392/job/15451237158?pr=407

Even though it seems to be included on that package:

jgalan@sultan2:~$ dpkg -L libmpfrc++-dev
/.
/usr
/usr/include
/usr/include/mpreal.h
/usr/share
/usr/share/doc
/usr/share/doc/libmpfrc++-dev
/usr/share/doc/libmpfrc++-dev/changelog.Debian.gz
/usr/share/doc/libmpfrc++-dev/changelog.gz
/usr/share/doc/libmpfrc++-dev/copyright
/usr/share/doc/libmpfrc++-dev/examples
/usr/share/doc/libmpfrc++-dev/examples/example.cpp
/usr/share/doc/libmpfrc++-dev/examples/makefile

@jgalan
Copy link
Member Author

jgalan commented Jul 30, 2023

Also the Geant4 tests validation is failing. Perhaps the Geant4 version is not the same?

@lobis
Copy link
Member

lobis commented Jul 30, 2023

I am not sure I follow but the library is installed on the image, you can verify by running:

lobis@sultan2:~$ docker run --pull always -it --rm ghcr.io/rest-for-physics/root-garfield-geant4:latest dpkg -L libmpfrc++-dev
latest: Pulling from rest-for-physics/root-garfield-geant4
Digest: sha256:6e2006433187da724b87d2464ff1b63d965b593e7d845f27c4c5544d3b22b743
Status: Image is up to date for ghcr.io/rest-for-physics/root-garfield-geant4:latest
/.
/usr
/usr/include
/usr/include/mpreal.h
/usr/share
/usr/share/doc
/usr/share/doc/libmpfrc++-dev
/usr/share/doc/libmpfrc++-dev/changelog.Debian.gz
/usr/share/doc/libmpfrc++-dev/copyright
/usr/share/doc/libmpfrc++-dev/examples
/usr/share/doc/libmpfrc++-dev/examples/example.cpp
/usr/share/doc/libmpfrc++-dev/examples/makefile

Version of dependencies can also be queried via:

lobis@sultan2:~$ docker run --pull always -it --rm ghcr.io/rest-for-physics/root-garfield-geant4:latest version.sh
latest: Pulling from rest-for-physics/root-garfield-geant4
Digest: sha256:6e2006433187da724b87d2464ff1b63d965b593e7d845f27c4c5544d3b22b743
Status: Image is up to date for ghcr.io/rest-for-physics/root-garfield-geant4:latest
- ROOT_VERSION: 6.28/04
- GEANT4_VERSION: 11.0.4
- GARFIELD_VERSION: e0a9f171

The version of Geant4 for this image seems to be different that what we are currently using. I will update this image to use the same as the current pipeline, hopefully that fixes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants