Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Independent track analysis for pure 3D tracks with XYZ hits #40

Open
jgalan opened this issue Feb 23, 2024 · 1 comment
Open

Independent track analysis for pure 3D tracks with XYZ hits #40

jgalan opened this issue Feb 23, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@jgalan
Copy link
Member

jgalan commented Feb 23, 2024

Recently there was some issues with XYZ tracks reported by @DavidDiezIb , and addressed also in #39.

It is a bit strange for me that in the following code lines

auto hitsBoth = {hitsXZ, hitsYZ};

the XZ and YZ hits are combined to produce XYZ observables.

Indeed, this is likely producing XYZ observables out of XZ and YZ hits. However, the pure XYZ hits might require dedicated attention. Also, the TrackAnalysis process is becoming too wide.

I think we should favor smaller and more atomic processes that target a reduced problem.

We could for instance have TRestTrack3DAnalysisProcess that will target only pure XYZ tracks produced with pixel readouts or pure MC simulation output. This process would serve only for those events that contain pure XYZ tracks, so there should be some error output in case we find other track types inside the input event.

Also, we may think to split into TRestTrackBasicAnalysisProcess and TRestTrack2DAnalysisProcess, etc.

I think atomic processes should be favored.

@jgalan jgalan added the enhancement New feature or request label Feb 23, 2024
@DavidDiezIb
Copy link
Member

TRestTrack3DAnalysisProcess implemented here: #43
Close related with Issue #41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants