Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RocksDB memory configuration is based on static and not the actual number of running partitions processors #2525

Open
tillrohrmann opened this issue Jan 22, 2025 · 1 comment

Comments

@tillrohrmann
Copy link
Contributor

Currently, we base our RocksDB memory budget on a statically configured number of partitions (num_partitions_to_share_memory_budget in StorageOptions). With the explicit provision step, users might provision the cluster with a different number of partitions than what was configured. Moreover, if we don't run all partitions on every worker node, then this number might even change again. Hence, we might configure the memory budget assigned to a column family currently incorrectly. The bad things could be OOMs (if we set the value too high) or not using the available memory as efficient as possible.

@tillrohrmann
Copy link
Contributor Author

fyi @AhmedSoliman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant