Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing span fields in state_machine::utils::apply_command #2877

Open
tillrohrmann opened this issue Mar 10, 2025 · 0 comments
Open

Confusing span fields in state_machine::utils::apply_command #2877

tillrohrmann opened this issue Mar 10, 2025 · 0 comments

Comments

@tillrohrmann
Copy link
Contributor

Some of the state_machine::utils::apply_command span fields are confusing since they appear multiple times. For example, restate.invocation.id, rpc.method, restate.invocation.target appear twice in the log output message below.

2025-03-10T12:36:11.211955Z DEBUG restate_worker::partition::state_machine
  Invoke inboxed
    rpc.service: KillTestSingleton/c735fb3a-4e2c-44dd-9d42-ad9c932eb107
on rt:pp-3
  in restate_worker::partition::state_machine::utils::apply_command
    otel.name: "apply-command: InvokerEffect"
    restate.state_machine.command: InvokerEffect(Effect { invocation_id: InvocationId { partition_key: 2691971143059952921, inner: InvocationUuid(2105477499437878611799103406223967318) }, kind: Failed(InvocationError { code: 409 Aborted, message: "killed", stacktrace: None }) }) 
    restate.invocation.id: inv_12dw5UBHriBL2DJ0pgfNmE46yAptW2rrMJ 
    restate.invocation.target: KillTestSingleton/c735fb3a-4e2c-44dd-9d42-ad9c932eb107/recursiveCall 
    rpc.service: KillTestSingleton 
    rpc.method: recursiveCall 
    restate.invocation.id: inv_12dw5UBHriBL6zDR4IfF2Ev9TdQHvK6rsZ 
    restate.invocation.target: KillTestSingleton/c735fb3a-4e2c-44dd-9d42-ad9c932eb107/recursiveCall 
    rpc.service: KillTestSingleton 
    rpc.method: recursiveCall
  in restate_worker::partition::run
    partition_id: 3

@slinkydeveloper should the first set of fields be the caller information?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant