Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider logging InvocationId using Display instead of Debug #2878

Open
tillrohrmann opened this issue Mar 10, 2025 · 0 comments
Open

Consider logging InvocationId using Display instead of Debug #2878

tillrohrmann opened this issue Mar 10, 2025 · 0 comments

Comments

@tillrohrmann
Copy link
Contributor

In the debug log output of the state machine commands, we seem to be logging the command via Debug. This has the effect that InvocationId is logged the following way:

restate.state_machine.command: InvokerEffect(Effect { invocation_id: InvocationId { partition_key: 2691971143059952921, inner: InvocationUuid(2105477499437878611799103406223967318) }, kind: Failed(InvocationError { code: 409 Aborted, message: "killed", stacktrace: None }) }) 

I think it would be more helpful to use the Display implementation of InvocationId, because then it would have the form inv_12dw5UBHriBL2DJ0pgfNmE46yAptW2rrMJ and would be searchable and easier to correlate with other log statements.

cc @slinkydeveloper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant