Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Which branch to checkout? #1

Open
leoshine opened this issue Aug 3, 2019 · 5 comments
Open

Which branch to checkout? #1

leoshine opened this issue Aug 3, 2019 · 5 comments

Comments

@leoshine
Copy link

leoshine commented Aug 3, 2019

Dear authors,

I've tried master as well as mister-ed branch,
but there're always quit a few import, deprecating errors.
So I'm wondering is the code to date now?

For example:
In Experiment_1.ipynb

this will go wrong because there's no "from_polytope_dict" in polytope

from polytope import Polytope, from_polytope_dict

This will go wrong as shown in the following

t = incremental_GeoCert(lp_norm, network, x_0, ax, plot_dir)

geometric-certificates/utilities.py in comparison_form(A, b, tolerance)
78 b is a 1d numpy array of shape (m)
79 """
---> 80 raise DeprecationWarning("DON'T DO THIS OUTSIDE OF BATCH ")
81 m, n = A.shape
82 # First scale all constraints to have b = +-1, 0

DeprecationWarning: DON'T DO THIS OUTSIDE OF BATCH

Thanks.

Best,
Leo

@wahrheit-git
Copy link

were you able to fix this? seems like another problem in line 314, best_adv = best_adv.cpu()
in geocert_oop.py

@leoshine
Copy link
Author

leoshine commented Sep 2, 2019

No. I didn't do that.

@revbucket
Copy link
Owner

Hey y'all, sorry for the radio silence (was traveling throughout August).

Thanks for expressing interest here, but right now the repo is full of deprecation errors resulting from deadline-induced performance hackery. One of my priorities in the next week is to clean things up and make this codebase more usable/add some more documentation. Sit tight and I'll close this issue once things are unbroken

@wahrheit-git
Copy link

Thanks. I look forward to it.

@revbucket
Copy link
Owner

Hey, so I've cleaned things up on master

The previous state of things was a complete mess, so maybe it's just best to reset entirely to what the master branch currently has. I've also replaced the experiments with two jupyter notebooks in the /examples/ directory. Let me know how these work for you, and if everything is okay, I'll close this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants