-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed default_auto_field to "django.db.models.BigAutoField" - Support more than 2**31 records in all models #159
Conversation
This is a major change and I recommend raising the version number accordingly (at least to 1.10 or something). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
cc'ing @frankwiles about the note on bumping a major and this is probably worth manually testing to see if/how Django upgrades fields like this. |
I thought about it and the change to I checked and I confirm that with Django<3.2 (tested with 3.1.13), a new migration is created if run |
Hi, According to https://www.djangoproject.com/download/, only Django versions >= 3.2 are supported right now. So you can consider accepting this pull request now while specifying the minimal Django version supported to 3.2. |
2078d16
to
90cbbe5
Compare
I rebased your branch on #182 and reached out to a few friends about the <3.2 support. Will follow up after I hear back. We are overdue for the 4.1 (soon 4.2) trove release and then dropping 3.6. 🔜 |
…ld" + added migrations. (Support more than 2**31 records in all models).
90cbbe5
to
7139b07
Compare
@uri-rodberg thank you! |
AppConfig: Changed default_auto_field to "django.db.models.BigAutoField" + added migrations.
(Support more than 2**31 records in all models).