Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Suggestion] TogglePM #19

Open
kchaney1508 opened this issue Aug 21, 2023 · 1 comment
Open

[Feature Suggestion] TogglePM #19

kchaney1508 opened this issue Aug 21, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@kchaney1508
Copy link

kchaney1508 commented Aug 21, 2023

Scope: include an additional command, "/togglepm" or similar (i.e., '/togglechat', '/togglemsgs', etc), to disable that specific users incoming and outgoing chat messages, including PMs and/or public chat.

Why: personally, I see this feature being useful for SMP communities where players don't want to communicate with each other.

[Example] Permission nodes & commands:

/togglepm; fairychat.command.togglepm - stop incoming/outgoing private messages from the player
/togglechat; fairychat.command.togglechat - stop incoming/outgoing public messages from the player
na; fairychat.bypass.togglepm - bypass a players togglepm status
na; fairychat.bypass.togglechat - bypass a players togglechat status

[Example] Chat messages:

Personal ifToggled
youCantMessagePublic: <red>This message cannot be delivered while your chat is disabled.<red>
youCantMessagePrivate: <red>This message cannot be delivered while your PMs are disabled.<red>

Public ifToggled
youCantDeliverPlayer: <red>You cannot message this player while their PMs are disabled.</red>
youCantMentionPlayer: <red>The player you mentioned has their public chat disabled.</red>

Notes:

  • I can see bypass.togglepm/togglechat being abused by server staff. This issue can be mitigated easily by denying the staff's permission nodes (if OP) or removing them entirely. Otherwise, suggesting a config option to opt-out of this permission node being enabled at all (enabled by default, of course).
  • I also see that staff aren't fit to manually enforce the players command choice (i.e., staff cannot force disable or enable someone elses PM/chat toggle choice).
  • @userName might also want a message if that player has their chat disabled - example above. Unsure if that's worth it, though?

Thanks you for this plugin. It's easy to understand, optimized and a straight arrow. God bless the developer.

Reply here if you need any other suggestions. Don't not have Discord, but my Guilded is https://www.guilded.gg/u/KC1508.

Regards,
KC1508

@rexlManu rexlManu moved this to Todo in FairyChat Aug 21, 2023
@rexlManu rexlManu added enhancement New feature or request good first issue Good for newcomers labels Aug 21, 2023
@rexlManu
Copy link
Owner

rexlManu commented Aug 21, 2023

Hi,

I like your suggested feature and I will add it to the project's todo list.

For mentions, I think I will just deny the user and sent him, that the player doesn't want to be "mentioned" at the moment.

I don't think there should be a bypass permission for togglechat. If it's really urgent for a staff, /pm should be sufficient for it.

@rexlManu rexlManu moved this from Todo to In Progress in FairyChat Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: In Progress
Development

No branches or pull requests

2 participants