From b4e4730447749b6758f24b9e86ac5b764d181cad Mon Sep 17 00:00:00 2001 From: Bob Bird Date: Fri, 15 Nov 2024 11:29:19 -0700 Subject: [PATCH] Address reviewer feedback --- lib/ramble/docs/results.rst | 4 ---- lib/ramble/ramble/test/reports.py | 11 +++++------ 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/lib/ramble/docs/results.rst b/lib/ramble/docs/results.rst index 40c696bac..2401a7e9d 100644 --- a/lib/ramble/docs/results.rst +++ b/lib/ramble/docs/results.rst @@ -47,10 +47,6 @@ Multiple plot types are supported, to aid in comparison of runs and common tasks For these plots, common operations are supported such as log axis, data grouping, and idealized line plotting. -While this functionality is very useful and powerful, it is not intended as a -wholesale replacement for uploading the data into more advanced offline -analysis tools. - ^^^^^^^^^^^^^^^ Strong and Weak Scaling Plots ^^^^^^^^^^^^^^^ diff --git a/lib/ramble/ramble/test/reports.py b/lib/ramble/ramble/test/reports.py index 37fbdd27d..4508a45aa 100644 --- a/lib/ramble/ramble/test/reports.py +++ b/lib/ramble/ramble/test/reports.py @@ -217,13 +217,12 @@ def test_scaling_plots(mutable_mock_workspace_path, tmpdir_factory, values): logy = False split_by = "simplified_workload_namespace" + where_query = None + results_df = prepare_data(results, where_query) + plot = plot_type(test_spec, normalize, report_dir_path, results_df, logx, logy, split_by) + with PdfPages(pdf_path) as pdf_report: - where_query = None - results_df = prepare_data(results, where_query) - plot = plot_type( - test_spec, normalize, report_dir_path, pdf_report, results_df, logx, logy, split_by - ) - plot.generate_plot_data() + plot.generate_plot_data(pdf_report) # Sort columns alphabetically, order is not important plot.output_df.sort_index(axis=1, inplace=True)