Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maim aura missing #4

Open
Macumbatbc opened this issue Jan 6, 2022 · 8 comments
Open

Maim aura missing #4

Macumbatbc opened this issue Jan 6, 2022 · 8 comments

Comments

@Macumbatbc
Copy link

Macumbatbc commented Jan 6, 2022

Hello Nug !

I'm just using NugPlateAuras since Bigdebuff has feature i don't need. i just discovered on my feral that there is no

  • Maim
  • Entangling roots
  • feral charge

debuff on nameplate.
I tried with Bigdebuff also, but it works with Bigdebuff.

image

image

BTW i have french client, idk if it could be this.

I'm waiting for your answer and if you want i can test all CC of all classes on ptr

thanks !

@d87
Copy link
Member

d87 commented Jan 6, 2022

Added Maim, but both feral charge and roots should be working, make sure your priority threshold is 45 or lower, otherwise roots aren't displayed.

@Macumbafeh
Copy link

How can i see that?

@d87
Copy link
Member

d87 commented Jan 6, 2022

Settings

@Macumbafeh
Copy link

But why does it works with Bigdebuff then?

@d87
Copy link
Member

d87 commented Jan 6, 2022

Because bigdebuffs is biddebuffs and it doesn't filter it out by default

@Macumbatbc
Copy link
Author

Macumbatbc commented Jan 6, 2022

Ok i see now sorry i thought you were talking about ingame settings and not addon settings >_<

image

It works now the icon is just smaller

Is it possible to enable all icons at the same scale?

Also i tried and maim works well, but not the feral charge because you need to add the Feral Charge effect spellID.
it's 45334 and not 19675, i just tested it and it works now.

@Macumbatbc
Copy link
Author

Macumbatbc commented Jan 6, 2022

Ok i just changed priority in the lib :)

That's for TBC but
I tested :

  • Mage CC are ok but only Dragon's Breath doesn't work
  • Priest is ok, i just don't understand why there is Mind flay but ok :)
  • Warlock only Shadow Fury doesn't work
  • Druid is all ok, i just tested it with a Tauren and Warstomp isn't in
  • Rogue is full ok
  • Hunter is ok
  • Shaman nothing to say
  • Paladin is ok, i tested it with Blood elfe and Arcane Torrent wasn't working. so i added it :
    A( 28730 , SILENCE) -- Arcane Torrent
    But it wasn't working.
  • Warrior is ok

I just saw that the racials spells are in Classic and not in TBC parts. so i copied them to TBC parts and now Arcane Torrent and Warstomp works.
So i added in TBC part
the Racial Chastise :
A({ 44047, 44041, 44043, 44044, 44045, 44046 }, ROOT) -- Chastise
Dragon's Breath
A({ 31661, 33041, 33042, 33043 }, { CROWD_CONTROL, effect = E_DISORIENT }) -- Dragon's Breath
Shadowfury
A({ 30414, 30283, 30413 }, { STUN, effect = E_STUN }) -- Shadowfury

@Macumbafeh
Copy link

I finished my work, since i'm a noob on github idk how to send my changes for other poeple that's why i wrote what i did.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants