Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link battles cannot start during the VS screen #5866

Closed
Nopinou opened this issue Dec 23, 2024 · 2 comments · Fixed by #5940
Closed

Link battles cannot start during the VS screen #5866

Nopinou opened this issue Dec 23, 2024 · 2 comments · Fixed by #5940
Labels
bug Bug category: battle-mechanic Pertains to battle mechanics status: confirmed This bug has been confirmed to exist in the codebase

Comments

@Nopinou
Copy link

Nopinou commented Dec 23, 2024

Description

Using the mgba multiplayer feature, I tested with colloseum single and double battles.

image
link_battle_1
link_battle_2

I noticed the small flickering during the VS screen, maybe there's something that is not correctly loaded ?

Version

1.10.0 (Latest release)

Upcoming/master Version

Both 1.10 (master) and upcoming

Discord contact info

Nopinou#8678

@Nopinou Nopinou added bug Bug category: battle-mechanic Pertains to battle mechanics status: unconfirmed This bug has not been reproduced yet labels Dec 23, 2024
@Nopinou
Copy link
Author

Nopinou commented Dec 28, 2024

If this can be of any help, I wanted to further investigate on this and tested this on my repo with an old branch, that was last synced with expansion around 7 months ago (last merged PR commit is #4462 ) and a quick link-single-battle worked correctly.

I tried to play around with DebugPrintfLevel in single battles to find where things go wrong, and I found that the host gets stuck in the second iteration of DoBattleIntro (it loops through BATTLE_INTRO_STATE_GET_MON_DATA and BATTLE_INTRO_STATE_LOOP_BATTLER_DATA, but does not reach BATTLE_INTRO_STATE_PREPARE_BG_SLIDE). At this stage, the connected player does not reach DoBattleIntro.

@AsparagusEduardo
Copy link
Collaborator

Confirmed in current master. I'll begin bisecting
mGBA_l9TZjoHSXR

@AsparagusEduardo AsparagusEduardo added status: confirmed This bug has been confirmed to exist in the codebase and removed status: unconfirmed This bug has not been reproduced yet labels Jan 2, 2025
@AsparagusEduardo AsparagusEduardo linked a pull request Jan 3, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug category: battle-mechanic Pertains to battle mechanics status: confirmed This bug has been confirmed to exist in the codebase
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants