Added the Gen. 4+ berries to gBerryCrush_BerryData #5937
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In regular Lunos fashion I confused the Berry Blender with the Berry Crush. Still, I'll leave this PR opened for now and test if it does fix the Berry Crush. |
|
Yeah, that should do it. Same change I made in my repo I'm just not able to fork expansion rn. Still worth a test I suppose. |
|
It kinda sort of works. I honestly can't tell if the freeze was a VBA thing or a game thing. berryCrushed.mp4 |
|
It's possible it crashed on the participant game due to an issue in tabulating the block sent by the leader... ( pokeemerald-expansion/src/berry_crush.c Line 3153 in 8ccb385 or just inaccurate emulator things(tm). I'll take a look when I get home. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the missing Gen. 4 berries' data to the
gBerryCrush_BerryDataarray.I picked the values somewhat randomly based on each berry's parameters at
gBerriesand then picking the closest to each berry that was already present ingBerryCrush_BerryData. For the Gen. 4+ Enigma Berry I just copy-pasted the Gen. 3 one though.Issue(s) that this PR fixes
Fixes #5935
Discord contact info
lunos#4026