Always skip issue when run is False (#82)

* Fixed always skip when run is set to False

* Switched resolves status to be a list instead of a generator since they were consumed and then not correctly checked from cache

* Accidently removed tests

* switched to tuple

pytest_jira.py

@@ -17,7 +17,7 @@
 import six
 
 PYTEST_MAJOR_VERSION = int(pytest.__version__.split(".")[0])
-DEFAULT_RESOLVE_STATUSES = ('closed', 'resolved')
+DEFAULT_RESOLVE_STATUSES = 'closed', 'resolved'
 DEFAULT_RUN_TEST_CASE = True
 
 
@@ -412,12 +412,12 @@ def pytest_configure(config):
 
     resolved_statuses = config.getvalue('jira_resolved_statuses')
     if isinstance(resolved_statuses, six.string_types):
-        resolved_statuses = (
+        resolved_statuses = [
             s.strip().lower() for s in resolved_statuses.split(',')
             if s.strip()
-        )
+        ]
     if not resolved_statuses:
-        resolved_statuses = DEFAULT_RESOLVE_STATUSES
+        resolved_statuses = list(DEFAULT_RESOLVE_STATUSES)
 
     if config.getvalue('jira') and config.getvalue('jira_url'):
         jira_connection = JiraSiteConnection(

tests/test_jira.py

@@ -750,3 +750,16 @@ def test_pass(jira_issue):
     """)
     result = testdir.runpytest(*PLUGIN_ARGS)
     result.assert_outcomes(0, 0, 1)
+
+
+def test_run_false_for_resolved_issue(testdir):
+    testdir.makeconftest(CONFTEST)
+    testdir.makepyfile("""
+        import pytest
+
+        @pytest.mark.jira("ORG-1412", run=False)
+        def test_pass():
+            assert True
+    """)
+    result = testdir.runpytest(*PLUGIN_ARGS)
+    result.assert_outcomes(1, 0, 0)