feat: rewrite in nushell #52
Conversation
There was a problem hiding this comment.
Firstly there is no rpk help command, running rhino-pkg will also throw an error. Running either rhino-pkg with no arguments OR rhino-pkg help should provide useful output to help the user as is the default behavior of the current rhino-pkg implementation.
Running rpk cleanup gives output in these weird boxes with no data contained inside of them:
Information actually does get formatted into a box on rpk remove as well:
Even more urgent is the fact that there are seemingly no checks for whether Nala is installed on the system. I didn't find any skimming the code, nor does it check when testing. Fix this.
|
Greetings, I am the user behind the backup and recovery ideas, which you can find here: #57 . I would be glad to continue the project and transfer those functions to this rewrite. I’d also like to contribute to the project, so I would appreciate your assistance in setting it up on my PC. Additionally, creating an app store version of this project seems like a great idea to me. This way, we can develop and maintain Rhino Linux's app store, similar to other distributions out there—take openSUSE's YaST, for example, which I greatly admire. I can try to build a very basic beta version soon so we can start working on it. Eventually, we could offer this app store to the world under Rhino Linux's name. Best regards, devtracer |
Hello again @devtracer It would be great if you could port functionality into the rewrite. There is currently an ongoing discussion as to whether we continue on rewriting rhino-pkg in Nushell, or whether we pivot to an alternative such as Go or Rust. You can find and contribute to the discussion here: rhino-linux/tracker#28 It would be best (in my opinion) to open up a separate feature proposal if you would wish to create/incorporate a graphical application store within Rhino Linux. You can do that here: https://github.com/rhino-linux/tracker Finally, I would like to ask that you would join our Discord (if you would like to), I personally believe that you are making excellent contributions, and would love to involve you in development discussions where possible, and most of our development / discussions happen in the Rhino Linux discord server. The invite can be found here: https://discord.gg/reSvc8Ztk3 |
I would prefer technical discussions about rhino-pkg to be here rather than on discord. |
Hi @ajstrongdev, Thank you for the update and the invite! I’d be happy to participate in the discussions and contribute further to the team. I’ll make sure to check out rhino-linux/tracker#28 soon. Regarding the graphical application store, I’ll open a separate feature proposal on the tracker to discuss it in more detail. I plan to develop the GUI app store's backend in a way that allows it to seamlessly attach and connect to the package manager. This approach will ensure a stable and seamless connection, even as the package manager undergoes frequent updates. I’m really thrilled to hear that you’re happy with my contributions so far—I truly appreciate the feedback! Thanks again for the invite; I’ll join the Discord server soon to start discussions! Best wishes, |
|
I've tested with
|
|
Hello, As you're building the next generation of the package, should the GUI application also be included in this build? I was thinking of an installation window where users would be able to press the installation button alongside choosing a package manager to install with. The GUI app's backend will lead to some functions that call these codes. Feel free to share what you think. I think users would like to try this app's beta version as well. |
@amirali-dashti Hello. Please do understand that the GUI application store is currently a proposal, this rewrite is not intending to nor will support functionality for that. Furthermore I feel as though, with the GUI app store issue still "a proposal" and not an agreed upon feature, that you might be getting a bit ahead of yourself 😄 What would be great is if someone could contribute support for the Nix and AM package managers into this rewrite, as that is where our focus should be at the moment, feel free to submit a Pull Request into the |
@ajstrongdev Thanks for the reply. I understand, I thought a basic, early agreement would be enough to start building a template version of the proposal alongside this new project, to check if whether this project passes and gets approved or not; similar to a laboratory's research process. I've tried Nix, and I have to say I've liked it so far. |
|
@ajstrongdev To confirm, as you've mentioned here, the GUI app will be continued once it passes the proposal stage 👍🙏 |
|
just did some testing with: pkgname="rhino-pkg-git"
source=("https://github.com/rhino-linux/rhino-pkg.git#branch=nushell")
arch=("all")
pkgver="2.0.0"
gives="rhino-pkg"
makedepends=("make")
pacdeps=("nutext-git")
pkgdesc="Rhino-pkg wrapper script"
maintainer=("Oren Klopfer <[email protected]>")
package() {
cd "${gives}"
DESTDIR="${pkgdir}" make install
mkdir -p "${pkgdir}/usr/bin"
install -Dm755 "${gives}" "${pkgdir}/usr/bin/${gives}"
ln -sf "/usr/bin/${gives}" "${pkgdir}/usr/bin/rpk"
}overall is very good, there was a search hanging issue I experienced a while back that I still need to test, but almost everything is quite solid now. Few minor things:
But again, overall great job and solid improvements. I also think it would be great if we could get the lists to spread out into multiple columns. |
We still need a way to add i18n.Done.