Merge pull request #14296 from colega/fix-matcher-string-with-empty-l…

…abel-name Fix `Matcher.String()` with empty label name
rhobs · Jun 19, 2024 · 5c41768 · 5c41768
2 parents f45b0fd + 6685cbc
commit 5c41768
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/model/labels/matcher.go b/model/labels/matcher.go
@@ -101,7 +101,7 @@ func (m *Matcher) shouldQuoteName() bool {
 		}
 		return true
 	}
-	return false
+	return len(m.Name) == 0
 }
 
 // Matches returns whether the matcher matches the given string value.

diff --git a/promql/parser/printer_test.go b/promql/parser/printer_test.go
@@ -148,6 +148,13 @@ func TestExprString(t *testing.T) {
 			in:  `{"_0"="1"}`,
 			out: `{_0="1"}`,
 		},
+		{
+			in: `{""="0"}`,
+		},
+		{
+			in:  "{``=\"0\"}",
+			out: `{""="0"}`,
+		},
 	}
 
 	for _, test := range inputs {