Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The API for setting resource isn't convenient #279

Open
simonpasquier opened this issue May 5, 2023 · 0 comments
Open

The API for setting resource isn't convenient #279

simonpasquier opened this issue May 5, 2023 · 0 comments

Comments

@simonpasquier
Copy link
Contributor

.spec.resources's description says "Define resources requests and limits for Monitoring Stack Pods" which is misleading because the resources requests are only applied to the Prometheus resource and we have no way to define requests for Alertmanager.

Instead of

spec:
  resources:
    requests:
      cpu: 200m
      memory: 1Gi

The API should probably look like

spec:
  prometheusConfig:
    resources:
      requests:
        cpu: 200m
        memory: 1Gi
  alertmanagerConfig:
    resources:
      requests:
        cpu: 200m
        memory: 1Gi

I didn't create a ticket in JIRA but I can do later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant