Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict Default self-hosted Runner Labels #478

Open
Kerruba opened this issue Nov 15, 2024 · 0 comments
Open

Restrict Default self-hosted Runner Labels #478

Kerruba opened this issue Nov 15, 2024 · 0 comments

Comments

@Kerruba
Copy link

Kerruba commented Nov 15, 2024

Currently, it is possible to add custom self-hosted runner labels to the runner-label checker using the following configuration:

self-hosted-runner:
    labels:
      - private-runner-label1
      - private-runner-label2

By default, the self-hosted label is considered a valid option for runners.

However, when using the Actions Runner Controller (ARC) to manage self-hosted runners on Kubernetes, it is not possible to assign multiple labels to the runner-set. Additionally, the default self-hosted label is not automatically added to the runner group in this setup.

As a result, the default self-hosted label often becomes an invalid option in such scenarios.

Proposal

It would be highly beneficial to provide an option in the configuration to restrict valid self-hosted runner labels to only those explicitly defined by the user.

For example, a new field could be introduced to disable the default acceptance of the self-hosted label unless explicitly included in the user-provided list.

This feature would improve compatibility with ARC and similar setups, ensuring labels are validated based on the user’s intended configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant