Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: batch checks read type correctly #202

Merged
merged 1 commit into from
Apr 28, 2024
Merged

Conversation

rhysnewell
Copy link
Owner

@rhysnewell rhysnewell commented Apr 24, 2024

Batch test was not correctly setting long_read_type in the config file due to missing medaka_model parameters in the parsed arguments. Additionally, the batch mode was not checking if the long read type was valid like other CLI usage does.

  • refactor medaka model list
  • refactor long read type list
  • fix missing long read type in batch parsing

@rhysnewell rhysnewell merged commit 9d97ef3 into dev Apr 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants