New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

normalisation suppressed if 1 entity is missing :id #25

Open

stevebuik opened this issue Jan 19, 2022 · 0 comments

stevebuik commented Jan 19, 2022 •

edited

Loading

this works as expected

(->> {:id   "100"
            :name "Steve"
            :cars [{:id          "123"
                    :name        "Audi"}
                   {
                    :id          "124" ; <<<<< comment/remove this line
                    :name        "Ford"}
                   {:id          "125"
                    :name        "Tesla"}]}
           dx/normalize)

but if one of the cars has no id, the none of the cars are normalised.

is this intentional?

it would be better for dev/debug if the valid cars were still normalised.

maybe a log msg could indicate that one was skipped? not sure how log tooling works and if that's something you consider desirable?

stevebuik mentioned this issue

pull with > join to N entities only returns first join results #26

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment