-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP8 compatibility #14
Comments
FYI, did the update on my fork and executed PHPCS with php8 compatibility checker to ensure nothing will be broken.
|
Another update is required for |
Just saw that PR #11 which looks like more or less the same as what I did |
Hello,
May I propose a PR to allow PHP8 to be used on this project ?
I quickly checked, it looks like the lonely issue is
php-http/client-common
which is not compatible with PHP8.I guess updating requirement from
^1.0
to^1.0|^2.0
should be enoughUnfortunately without any tests some issue may appears at some points as some methods don't exist anymore on PHP8 :| I should be able anyway to double check that by using the branch on my project and check on my own CI if it's OK (at least for the part used by my project)
Based on changelog, It seems nothing need to be updated as removed options don't seems to be used there.
The text was updated successfully, but these errors were encountered: