Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP8 compatibility #14

Open
yoanmLf opened this issue Jan 6, 2022 · 3 comments
Open

PHP8 compatibility #14

yoanmLf opened this issue Jan 6, 2022 · 3 comments

Comments

@yoanmLf
Copy link

yoanmLf commented Jan 6, 2022

Hello,

May I propose a PR to allow PHP8 to be used on this project ?

I quickly checked, it looks like the lonely issue is php-http/client-common which is not compatible with PHP8.
I guess updating requirement from ^1.0 to ^1.0|^2.0 should be enough
Unfortunately without any tests some issue may appears at some points as some methods don't exist anymore on PHP8 :| I should be able anyway to double check that by using the branch on my project and check on my own CI if it's OK (at least for the part used by my project)

Based on changelog, It seems nothing need to be updated as removed options don't seems to be used there.

@yoanmLf
Copy link
Author

yoanmLf commented Jan 6, 2022

FYI, did the update on my fork and executed PHPCS with php8 compatibility checker to ensure nothing will be broken.
It looks OK
php8-check
Also checked for php 8.1, same result 👌

Let me know, If I can open a PR from there https://github.com/yoanmLf/php-rabbitmq-management-api.
ℹ️ Finally moved under TheFork, PHP 8 compatible version is available there https://github.com/lafourchette/php-rabbitmq-management-api/releases/tag/2.2.0
Thanks

@yoanmLf
Copy link
Author

yoanmLf commented Jan 6, 2022

Another update is required for php-http/httplug, requirement should be ^1.0|^2.0 too. It seems there is no breaking change from v1 to v2 (as said This version is no BC break for consumers using HTTPlug. However, HTTP clients that implement HTTPlug need to adjust because we add return type declarations.)

@yoanmLf
Copy link
Author

yoanmLf commented Jan 7, 2022

Just saw that PR #11 which looks like more or less the same as what I did

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant