Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory leak in MulticastService #99

Open
ak250995 opened this issue Nov 6, 2020 · 1 comment · May be fixed by #106
Open

Memory leak in MulticastService #99

ak250995 opened this issue Nov 6, 2020 · 1 comment · May be fixed by #106

Comments

@ak250995
Copy link

ak250995 commented Nov 6, 2020

When created, MulticastService subscribes to static NetworkAddressChangedEvent, and doesn't unsubscribe from it anywhere.
Creating MulticastService instances leads to a memory leak.

2020-09-30 16_00_49-Ncr Isip FacadeService – JetBrains dotMemory (Administrator)
@schotime
Copy link

schotime commented Jun 5, 2021

I believe this causes it.

net-mdns/src/MulticastService.cs

Line 342 in b9f2f81

NetworkChange.NetworkAddressChanged += OnNetworkAddressChanged;

It needs to remove the event handler when you dispose the service.

@schotime schotime linked a pull request Jun 5, 2021 that will close this issue
Open
schotime added a commit to schotime/net-mdns that referenced this issue Jun 5, 2021
@schotime
Remove event handler for NetworkChange.NetworkAddressChanged
4a69eaa 
fixes richardschneider#99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove event handler for NetworkChange.NetworkAddressChanged schotime/net-mdns
2 participants
@schotime @ak250995