You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is it feasible to add redisSetTimeout (from hiredis) as an option to most calls? I'm specifically looking at the $subscribe model, where I'm a little daunted by
NOTE: you need to be careful here - hiredis internally uses a blocking read which cannot be interrupted with Ctrl-C once started unless a message is received on the channels being listened to!
Shallow research suggests that it generally can be used before redisGetReply ... admittedly I'm not certain if that's used for most redis verbs.
The text was updated successfully, but these errors were encountered:
@richfitz, are you still maintaining this package? I don't expect immediate discussion or code changes for issues, but it's been a long time since you committed something to the master branch. Thanks!
Hi @r2evans - yes, still maintaining the package, but it's in a state where it basically does everything I need and so I've not felt the need to change it. I tend not to see github notifications unfortunately (and especially not this year).
If you want to contribute a PR for this, I'd gladly review/merge it. I'd suggest putting the timeout into the redis configuration so it's taken and validated just once, and then passed through via redisGetReply wherever needed.
If you're not in a position to do this, I will see this issue next time I do some redux work, though I can't say when that would be.
Is it feasible to add
redisSetTimeout
(from hiredis) as an option to most calls? I'm specifically looking at the$subscribe
model, where I'm a little daunted byShallow research suggests that it generally can be used before
redisGetReply
... admittedly I'm not certain if that's used for most redis verbs.The text was updated successfully, but these errors were encountered: