Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redisSetTimeout? #33

Open
r2evans opened this issue Feb 13, 2020 · 2 comments
Open

redisSetTimeout? #33

r2evans opened this issue Feb 13, 2020 · 2 comments

Comments

@r2evans
Copy link

r2evans commented Feb 13, 2020

Is it feasible to add redisSetTimeout (from hiredis) as an option to most calls? I'm specifically looking at the $subscribe model, where I'm a little daunted by

NOTE: you need to be careful here - hiredis internally uses a blocking read which cannot be interrupted with Ctrl-C once started unless a message is received on the channels being listened to!

Shallow research suggests that it generally can be used before redisGetReply ... admittedly I'm not certain if that's used for most redis verbs.

@r2evans
Copy link
Author

r2evans commented Sep 17, 2020

@richfitz, are you still maintaining this package? I don't expect immediate discussion or code changes for issues, but it's been a long time since you committed something to the master branch. Thanks!

@richfitz
Copy link
Owner

Hi @r2evans - yes, still maintaining the package, but it's in a state where it basically does everything I need and so I've not felt the need to change it. I tend not to see github notifications unfortunately (and especially not this year).

If you want to contribute a PR for this, I'd gladly review/merge it. I'd suggest putting the timeout into the redis configuration so it's taken and validated just once, and then passed through via redisGetReply wherever needed.

If you're not in a position to do this, I will see this issue next time I do some redux work, though I can't say when that would be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants